Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Automated CherryPick Update for release-v4.3 #4175

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

sealos-ci-robot
Copy link
Member

@sealos-ci-robot sealos-ci-robot commented Oct 26, 2023

🤖 Generated by Copilot at 6e89410

Summary

🐛🚫🚀

This pull request fixes a bug in the apply command that would report success even if there were no resources to apply or if there were errors. It changes the updateStatus function in pkg/apply/applydrivers/apply_drivers_default.go to return early if there are no new images, and removes the unused NewSuccessCommandCondition function from pkg/types/v1beta1/cluster.go.

apply command fixed
No success if nothing ran
Autumn leaves unused code

Walkthrough

  • Add a return statement to avoid updating the command condition with a success status and the new images if the apply command did not run any resources on the cluster (link)
  • Remove the unused helper function NewSuccessCommandCondition that created a command condition object with a success status and a message for the apply command (link)

Automated changes by create-pull-request GitHub action

@cuisongliu cuisongliu merged commit 579a016 into release-v4.3 Oct 26, 2023
31 of 32 checks passed
@cuisongliu cuisongliu deleted the cherry-pick-release-v4.3-4170 branch October 26, 2023 06:40
@sweep-ai
Copy link

sweep-ai bot commented Oct 26, 2023

Apply Sweep Rules to your PR?

  • Apply: Leftover TODOs in the code should be handled.
  • Apply: All new business logic should have corresponding unit tests in the tests/ directory.
  • Apply: Any clearly inefficient or repeated code should be optimized or refactored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants